[test] Remove (broken) EMTEST_BROWSER_PORT test setting #23113
Merged
+30
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
browser_reporting
branch
3 times, most recently
from
6b5982b to
0530cf1
Compare
sbc100
force-pushed
the
browser_reporting
branch
2 times, most recently
from
eb8e339 to
6ee004b
Compare
sbc100
changed the title
kripken
approved these changes
Dec 10, 2024
sbc100
force-pushed
the
browser_reporting
branch
from
6ee004b to
d99a399
Compare
sbc100
force-pushed
the
browser_reporting
branch
from
d99a399 to
040fc9e
Compare
The `browser_reporting.js` file (which does most of the reporting these days) was not honoring it anyway. I've never found the need to configure this in all the years I've been working on emscripten so hopefully we don't need to bring it back.
sbc100
force-pushed
the
browser_reporting
branch
from
040fc9e to
2fbe054
Compare
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
…ore#23113) The `browser_reporting.js` file (which does most of the reporting these days) was not honoring it anyway. I've never found the need to configure this in all the years I've been working on emscripten so hopefully we don't need to bring it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
browser_reporting.jsfile (which does most of the reporting these days) was not honoring it anyway. I've never found the need to configure this in all the years I've been working on emscripten so hopefully we don't need to bring it back.